-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add 'cyclop' linter #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'cyclop' linter #1738
Conversation
Hey, thank you for opening your first Pull Request ! |
Hello, to be able to sign the CLA you have to add the email that you are using inside your GitHub account settings https://github.com/settings/emails |
Could you explain what is for you the difference between your linter the other linters on the same subjects (like gocyclo, funlen, gocognit, ...)? Otherwise, could you run a |
Hi @ldez! Of course :) Firstly, I hope I answered your questions! If you have more, don't hesitate to ask :) |
https://github.com/fzipp/gocyclo seems maintained, at least there is a lot of commits in the past year. https://github.com/fzipp/gocyclo/commits/main |
@bkielbasa could you rebase your PR? |
@ldez done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, @bkielbasa — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
https://github.com/bkielbasa/cyclop