Support SuggestedFixes #2609
Closed
Support SuggestedFixes #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
force-pushed
the
sv/support-suggested-fixes
branch
2 times, most recently
from
89b7513 to
9ed5793
Compare
|
@ldez Ok, the PR is ready. I understand that the solution is not the best possible, but I still don't understand how to manually create a Replacement object for a TextEdit. This is kind of workaround PS: |
SVilgelm
force-pushed
the
sv/support-suggested-fixes
branch
from
9ed5793 to
1371f5c
Compare
Conver the SuggesterFixes to Replacement by: 1. applying the fixes to a file in memory 2. creating a diff by comparing with original file 3. using `ExtractIssuesFromPatch` function to create the issues
SVilgelm
force-pushed
the
sv/support-suggested-fixes
branch
from
1371f5c to
43d956f
Compare
SVilgelm
force-pushed
the
sv/support-suggested-fixes
branch
from
43d956f to
d766d2c
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conver the SuggesterFixes to Replacement by:
ExtractIssuesFromPatchfunction to create the issues