dev: follow standards by using 'want' instead of 'ERROR' for tests #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/test-parsing
branch
from
6249032 to
dc98d07
Compare
ldez
changed the title
ldez
force-pushed
the
feat/test-parsing
branch
from
33b6fe4 to
ae02093
Compare
ldez
force-pushed
the
feat/test-parsing
branch
2 times, most recently
from
79345a7 to
3b8e8f8
Compare
ldez
force-pushed
the
feat/test-parsing
branch
from
3b8e8f8 to
df628f6
Compare
bombsimon
reviewed
Aug 20, 2022
|
@bombsimon thank you for the review 👍 |
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the test system.
Inspired by https://pkg.go.dev/golang.org/x/tools/go/analysis/analysistest#Run
extra: I also add a new directives:
golangcitest:expected_exitcodedirective. Still the same goal: robustness and high-quality test outputs.Fixes #1222