dev: enable revive linter with default config

[alexandear]

This PR enables revive in the .golangci.yml config.

[ldez]

All the linters are always not-used for the golangci-lint repository when they are introduced, it's expected.

As we run on several versions of golangci-lint in the CI, a problem exists when a linter doesn't exist yet.
Also, the changes in linters can lead to an unresolvable situation for the same reason.

So, we have to take care of enabling a linter for the golangci-lint repository.

[ldez]

I don't understand why this PR is in draft, can you explain it?

[alexandear]

I need to add manually revive rules because they are disabled by default. That's why drafted PR.

[ldez]

I need to add manually revive rules because they are disabled by default. That's why drafted PR.

revive rules are not disabled by default: there is a default rule set.

In this context, it's better to prepare your branch locally before opening a PR.
Each PR and each commit send notifications.

I resolved all comments. Looks like it's a GitHub's bug.

[ldez]

Never dismiss a review and especially mine.

When you resolve comments, you can ask for another review but not dismiss a review, I will remove the dismiss right.

[thejan2009]

Hey, revive config works different than expected. With this change the linter was enabled, but its rule set was reduced to just a disabled unexported-return. After removing revive: from linters-config:, we get the following:

$ ./golangci-lint run --max-same-issues 1
pkg/golinters/gocritic_test.go:59:22: unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
func (l *tLog) Child(name string) logutils.Log { return nil }
                     ^
pkg/golinters/gocritic_test.go:61:25: unused-parameter: parameter 'level' seems to be unused, consider removing or renaming it as _ (revive)
func (l *tLog) SetLevel(level logutils.LogLevel) {}
                        ^
pkg/printers/checkstyle.go:44:27: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (p Checkstyle) Print(ctx context.Context, issues []result.Issue) error {
                          ^
pkg/printers/junitxml.go:85:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
        if err := enc.Encode(res); err != nil {
                return err
        }
pkg/logutils/logutils.go:82:16: unused-parameter: parameter 'format' seems to be unused, consider removing or renaming it as _ (revive)
func nopDebugf(format string, args ...any) {}
               ^
pkg/result/processors/sort_results.go:95:47: unexported-return: exported method Compare returns unexported type processors.compareResult, which can be annoying to use (revive)
func (cmp ByName) Compare(a, b *result.Issue) compareResult {
                                              ^

[alexandear]

@thejan2009 thank you for pointing this out. I will create a PR to enable recommended rules.