add protogetter linter

[ghostiam]

ProtoGetter analyzes code and helps detect direct protobuf field accesses that could give rise to panic.

The linter suggests using getters:

m.GetFoo().GetBar().GetBaz()

instead of direct field access:

m.Foo.Bar.Baz

A little more information: golang/protobuf#54 (comment)

Examples:

With getters:

// If one of the methods returns `nil` we will receive 0 instead of panic.
m.GetFoo().GetBar().GetBaz().GetInt() 

With fileds:

// If at least one structure in the chains is not initialized, we will get a panic. 
m.Foo.Bar.Baz.Int

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[ldez]

In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements.

• The CLA must be signed

Pull Request Description

• It must have a link to the linter repository.
• It must provide a short description of the linter.

Linter

• It must not be a duplicate of another linter or a rule of a linter. (the team will help to verify that)
• It must have a valid license (AGPL is not allowed) and the file must contain the required information by the license, ex: author, year, etc.
• The linter repository must have a CI and tests.
• It must use go/analysis.
• It must have a valid tag, ex: v1.0.0, v0.1.0.
• It must not contain init().
• It must not contain panic().
• It must not contain log.fatal(), os.exit(), or similar.
• It must not modify the AST.
• It must not have false positives/negatives. (the team will help to verify that)
• It must have tests inside golangci-lint.

The Linter Tests Inside Golangci-lint

• They must have at least one std lib import.
• They must work with T=<name of the linter test file>.go make test_linters. (the team will help to verify that)

.golangci.reference.yml

• The linter must be added to the list of available linters (alphabetical case-insensitive order).
  • enable and disable options
• If the linter has a configuration, the exhaustive configuration of the linter must be added (alphabetical case-insensitive order)
  • The values must be different from the default ones.
  • The default values must be defined in a comment.
  • The option must have a short description.

Others Requirements

• The files (tests and linter) inside golangci-lint must have the same name as the linter.
• The .golangci.yml of golangci-lint itself must not be edited and the linter must not be added to this file.
• The linters must be sorted in the alphabetical order (case-insensitive) in the Manager.GetAllSupportedLinterConfigs(...) and .golangci.reference.yml.
• The load mode (WithLoadMode(...)):
  • if the linter doesn't use types: goanalysis.LoadModeSyntax
  • goanalysis.LoadModeTypesInfo required WithLoadForGoAnalysis() in the Manager.GetAllSupportedLinterConfigs(...)
• The version in WithSince(...) must be the next minor version (v1.X.0) of golangci-lint.
• WithURL() must contain the URL of the repository.

Recommendations

• The linter should not use SSA. (SSA can be a problem with generics)
• The linter repository should have a readme and linting.
• The linter should be published as a binary. (useful to diagnose bug origins)

---

The golangci-lint team will edit this comment to check the boxes before and during the review.

The code review will start after the completion of those checkboxes (except for the specific items that the team will help to verify).

If the author of the PR is a member of the golangci-lint team, he should not edit this message.

This checklist does not imply that we will accept the linter.

[ldez]

FYI 0.0.x are not semver complaint because a bug fix cannot happen before a minor release or an impossible initial version v0.0.0.

PATCH version when you make backward compatible bug fixes

https://semver.org/

How should I deal with revisions in the 0.y.z initial development phase?

The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.

https://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase

[ghostiam]

@ldez I fixed the version

[ldez]

some elements don't fit our checklist (see my previous message)

[ghostiam]

The files (tests and linter) inside golangci-lint must have the same name as the linter.

Because my linter tests require a dependency on protobuf, the test is in
test/testdata/protogolint/protogolint.go with go.mod and go.sum
instead of
test/testdata/protogolint.go

They must have at least one std lib import.

I'm importing fmt

They must work with T=.go make test_linters. (the team will help to verify that)

T=protogolint make test_linters

GL_TEST_RUN=1 go test -v ./test -count 1 -run TestSourcesFromTestdata/protogolint
=== RUN   TestSourcesFromTestdata
    linters_test.go:21: testdata/*.go
--- PASS: TestSourcesFromTestdata (0.20s)
=== RUN   TestSourcesFromTestdataSubDir
=== RUN   TestSourcesFromTestdataSubDir/protogolint
    linters_test.go:40: testdata/protogolint/*.go
=== RUN   TestSourcesFromTestdataSubDir/protogolint/protogolint.go
=== PAUSE TestSourcesFromTestdataSubDir/protogolint/protogolint.go
=== CONT  TestSourcesFromTestdataSubDir/protogolint/protogolint.go
level=info msg="[test] ran [<redacted>/src/github.com/golangci/golangci-lint/golangci-lint run --internal-cmd-test --no-config --allow-parallel-runners --disable-all --out-format=json --max-same-issues=100 -Eprotogolint protogolint.go] in  485.652333ms"
level=info msg="[test] ran [<redacted>/src/github.com/golangci/golangci-lint/golangci-lint run --internal-cmd-test --no-config --allow-parallel-runners --disable-all --out-format=json --max-same-issues=100 -Etypecheck -Eprotogolint protogolint.go] in  229.036959ms"
--- PASS: TestSourcesFromTestdataSubDir (0.91s)
    --- PASS: TestSourcesFromTestdataSubDir/protogolint (0.19s)
        --- PASS: TestSourcesFromTestdataSubDir/protogolint/protogolint.go (0.72s)
PASS
ok      github.com/golangci/golangci-lint/test  2.295s

[Antonboom]

ghostiam/protogetter#1

[ldez]

LGTM