dev: sync checker with x/[email protected] #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/sync-checker
branch
from
ec608b9 to
2f111e5
Compare
ldez
changed the title
bombsimon
approved these changes
Dec 7, 2024
|
|
||
| // disallow calls after Run | ||
| // correct result type? |
There was a problem hiding this comment.
What is the question here? Why they're different? The code seems to properly check the difference and return a well format error. Should the comment indicate that it's not known why they would be different?
There was a problem hiding this comment.
it's a copy of the original comment 😉
https://github.com/golang/tools/blob/v0.28.0/go/analysis/checker/checker.go#L360
I think this is not a question but an explanation of the section.
There was a problem hiding this comment.
🤦 Oh sorry. I thought it was you since it was a lone diff, should've checked upstream first!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code borrowed from x/tools
Continuation of the work done inside #5109
I still have not found the Lost Ark but I am near the Temple of Doom 😸