Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfsprint: add ignore-tests option #5356

Closed

Conversation

miparnisari
Copy link

Copy link

boring-cyborg bot commented Jan 28, 2025

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

@miparnisari miparnisari marked this pull request as ready for review January 28, 2025 20:27
@ldez ldez added the declined label Jan 28, 2025
@ldez
Copy link
Member

ldez commented Jan 28, 2025

Hello,

this option is not present because there is a global option to exclude tests.

run:
  test: false

https://golangci-lint.run/usage/configuration/#run-configuration

This option is incompatible with the global option: if run.tests: false and perfsprint.ignore-tests: false then it doesn't work.

if you need to ignore reports from perfsprint on test files:

issues:
  exclude-rules:
    - path: (.+)_test\.go
      linters:
        - perfsprint

Thank you anyway

@ldez ldez closed this Jan 28, 2025
@ldez ldez changed the title add test option to perfsprint linter perfsprint: add ignore-tests option Jan 28, 2025
@miparnisari
Copy link
Author

Thank you @ldez that was very helpful context :)

@ldez
Copy link
Member

ldez commented Jan 28, 2025

@miparnisari I saw you are working for @auth0 / @okta.

Maybe this PR was related to something outside your work at those companies, and so my request may feel weird.

Have you read this issue about the v2 of golangci-lint? #5300

In this context, I was wondering if you could kindly inquire with your company about the possibility of supporting golangci-lint?

I know the question is off-topic, if you don't feel comfortable with this request, I fully understand, and you can ignore my request.

@miparnisari
Copy link
Author

@ldez absolutely. I will ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants