-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: golines formatter #5432
feat: golines formatter #5432
Conversation
Nice! Given the fork it doesn't look like there's any plans to sync with the maintainers if they would be interested to do or accept changes to make the original repo compatible with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should .golangci.next.reference.yml
be updated?
I will just update the json schema, the documentation will be rewritten because the 1st PR on formatters was just a compatibility layer, I will drop this layer and write the doc for all the formatters. All the references will be updated but I don't want to do the job twice. |
In fact, it is not really possible because some elements inside the core of golines cannot be removed. As you can think, before forking I evaluated the other possibilities, but there are no trivial and non-highly invasive modifications. |
Add
golines
as formatter.golines
is designed as a CLI, so I created a fork with minimal changes to be usable as a library.https://github.com/golangci/golines
The readme of the repository explains all the changes.
Fixes #1914
Related to #5296 (comment)
Related to #3983