Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove options #5464

Merged
merged 2 commits into from
Feb 23, 2025
Merged

feat: remove options #5464

merged 2 commits into from
Feb 23, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 22, 2025

Conflicting Options

The options related to test or generated files are conflicting with the global option to handle test or generated files.

For example, if test files are ignored globally, an option on a linter that allow test files analysis will not work.
Same thing for generated files.

Case Insensitivity

The option case-sensitive has been removed of exclusions.rules , so it should also be removed of severity.
This option was not consistent because it was only about 2 fields (text, source) of rules.
This option can be replaced by prefixing the regexp with (?i).

@ldez ldez added area: config Related to .golangci.yml and/or cli options topic: cleanup Related to code, process, or doc cleanup labels Feb 22, 2025
@ldez ldez added this to the v2-unreleased milestone Feb 22, 2025
@ldez ldez requested review from alexandear and bombsimon February 23, 2025 21:43
@ldez ldez merged commit 378dfbd into golangci:main Feb 23, 2025
18 checks passed
@ldez ldez deleted the feat/remove-options branch February 23, 2025 22:58
@busser busser mentioned this pull request Mar 14, 2025
Closed
@ldez ldez modified the milestones: v2-unreleased, v2 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants