feat: merge staticcheck, stylecheck, gosimple #5487
Merged
+731
−463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
requested review from
bombsimon and
alexandear
and removed request for
bombsimon
alexandear
approved these changes
Mar 4, 2025
Closed
|
Do note that |
|
Could quickfixes be part of what you defined as a "preset" ? So we can disable them if needed For now, I silenced Morgan Law one QF1001 that is terribly noisy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the
staticcheckanalyzers (stylecheck,gosimple,staticcheck) together.I'm doing that because this is how
staticcheckworks.By doing this merge, in addition to removing the default exclusions and removing alternative names in previous PRs, the integration of
staticcheckwill work more likestaticcheckthe binary.The initial decision to not merge all the analyzers was to not be breaking when
megacheck(the previous name ofstaticcheck) was rewritten.The v2 is the right moment to break and try to have a better implementation.
This PR also adds a new set of
staticcheckanalyzers calledquickfixto followstaticcheckthe binary.