fix: formatters shound't be enabled/disabled as linters #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
ldez
force-pushed
the
fix/enable-formatters
branch
from
63aa2af to
5023d7d
Compare
ldez
force-pushed
the
fix/enable-formatters
branch
from
5023d7d to
80add7a
Compare
alexandear
reviewed
Mar 11, 2025
alexandear
approved these changes
Mar 11, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created the
fmtcommand, it was for the v1, so I created a compatibility layer.The formatters should be enabled only inside the
formatterssection and not inside thelinterssection.The enabled formatters will still be run as linters when using the
runcommand.