Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check version of the configuration #5524

Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat: check version of the configuration #5524

merged 1 commit into from
Mar 11, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 11, 2025

Checks the version of the configuration.

@ldez ldez added enhancement New feature or improvement area: CLI Related to CLI labels Mar 11, 2025
@ldez ldez added this to the v2-unreleased milestone Mar 11, 2025
@ldez ldez marked this pull request as draft March 11, 2025 16:25
@ldez ldez force-pushed the feat/check-version branch from 8dd44f5 to 9e1d5e0 Compare March 11, 2025 16:34
@ldez ldez marked this pull request as ready for review March 11, 2025 16:34
bombsimon
bombsimon reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this important? Do we plan to rely on the version somewhere?

@ldez
Copy link
Member Author

ldez commented Mar 11, 2025

This is important because I'm 100% sure that people, that use latest, will try to run the v2 with v1 configuration.

@bombsimon
Copy link
Member

This is important because I'm 100% sure that people, that use latest, will try to run the v2 with v1 configuration.

I think you're 100% right 😅

@ldez ldez merged commit a424bbe into golangci:main Mar 11, 2025
18 checks passed
@ldez ldez deleted the feat/check-version branch March 11, 2025 19:57
@busser busser mentioned this pull request Mar 14, 2025
Closed
@ldez ldez modified the milestones: v2-unreleased, v2 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: CLI Related to CLI enhancement New feature or improvement
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @bombsimon