Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve staticcheck migration #5545

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 13, 2025

Disables staticcheck only if the 3 linters (staticcheck, stylecheck, gosimple) are disabled.

This is required because the migration can result in an inconsistent state where staticcheck is enabled and disabled.

@ldez ldez added bug Something isn't working area: migration labels Mar 13, 2025
@ldez ldez added this to the v2-unreleased milestone Mar 13, 2025
@ldez ldez merged commit 3f6f904 into golangci:main Mar 13, 2025
19 checks passed
@ldez ldez deleted the fix/migrate-staticcheck branch March 13, 2025 18:42
@busser busser mentioned this pull request Mar 14, 2025
Closed
@ldez ldez modified the milestones: v2-unreleased, v2 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migration bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants