Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unparam #5583

Closed
wants to merge 1 commit into from
Closed

Conversation

FGasper
Copy link

@FGasper FGasper commented Mar 19, 2025

Dependabot seems to have missed this one, which was fixed weeks ago.

@ldez ldez closed this Mar 19, 2025
@ldez ldez added the declined label Mar 19, 2025
@ldez ldez changed the title Update unparam to fix https://github.com/mvdan/unparam/issues/85 Update unparam Mar 19, 2025
@ldez
Copy link
Member

ldez commented Mar 19, 2025

The branch master is related to v1 but the v1 is now locked: #5300 (comment)

@FGasper
Copy link
Author

FGasper commented Mar 19, 2025

@ldez Are you saying this crash can’t be fixed except in v2?

@ldez
Copy link
Member

ldez commented Mar 19, 2025

Your question feels a bit aggressive.

Do you read the related issue?

@FGasper
Copy link
Author

FGasper commented Mar 19, 2025

@ldez I didn’t mean to be aggressive and am sorry to have come across that way.

I’m just wondering how this issue can be fixed. main doesn’t work for us because it currently rejects our v1 config files. The contributor docs still say to open PRs against master.

@ldez
Copy link
Member

ldez commented Mar 19, 2025

@FGasper I think you can understand that I will not create a bug fix for v1 unless special circumstances because the maintenance of the v1 should stop at some point, even if there are bugs.

If I begin to accept v1 modifications, the maintenance will never stop.

So I need to define a "rule", and this "rule" will be valid only before the v2 release: I invite your company (MongoDB Inc.) to sponsor the project.

Like that, maintenance is constrained through time and money, I think it's fair.

The v2 release should happen very soon.

My initial plan was to create a v2 release 3 days ago, but I spent those days diagnosing a complex bug and doing v2 preparation and checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants