fix: forbidigo migration #5606
Merged
fix: forbidigo migration #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
added a commit
to riverqueue/river
that referenced
this pull request
Mar 25, 2025
For better or rwose, golangci-lint has released a v2 [1] that's incompatible with v1. It'll only be a matter of time until we're forced to upgrade to it, so I figure we may as well do it early. There's a bunch of new obnoxious linters that I've disabled. Most of these complain about "cyclomatic complexity" or "cognitive complexity" or functions being too long (they all seem to want everything broken down into functions of ten lines). Aside from that, `testifylint` seems to have gotten even more effective at finding misuses of testify, so it fixed a bunch more arguable misuses of various assertions, which seems good for normalizing code. The structure of the YAML file changes fairly significantly, but it's all basically the same thing with various aspects reorganized. I made the new one using the built-in `golangci-lint migrate` and copied comments over manually. If we can get this in, the next step will be to distribute it out to other River projects. Most of them are using copies of this repo's configuration file, so it should be pretty easy to do. [1] https://ldez.github.io/blog/2025/03/23/golangci-lint-v2/ [2] golangci/golangci-lint#5606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5602