Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy golines settings during linter settings load #5607

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

mgabeler-lee-6rs
Copy link
Contributor

@mgabeler-lee-6rs mgabeler-lee-6rs commented Mar 24, 2025

This fixes the issue retaining the existing code pattern, but I'm wondering why we don't just do this instead of checking for each enabled formatter:

l.cfg.Linters.Settings.FormatterSettings = l.cfg.Formatters.Settings

I'm assuming for now that there is a good reason :)

Fixes #5603

@ldez ldez self-requested a review March 24, 2025 17:57
@ldez ldez added bug Something isn't working area: formatters/fmt labels Mar 24, 2025
@ldez ldez added this to the v2-unreleased milestone Mar 24, 2025
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you ❤️

@ldez ldez merged commit 97f2fd6 into golangci:main Mar 24, 2025
19 checks passed
@ldez ldez modified the milestones: v2-unreleased, v2.0 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: formatters/fmt bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golines: settings not obeyed during run
2 participants