-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: add note about golangci-lint v2 integration in VS Code #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds a note to the docs about how to integrate golangci-lint v2 with VS Code since the Go extension's stable version does not support it yet. For more information on this, you can refer to the linked [vscode-go#3732](golang/vscode-go#3732 (comment)) issue comment. Signed-off-by: lvlcn-t <[email protected]>
Hey, thank you for opening your first Pull Request ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lvlcn-t Unfortunately the instructions in https://golangci-lint.run/welcome/integrations/#visual-studio-code do not work for golangci-lint v2 (github.com/golangci/golangci-lint/v2/cmd/[email protected]). Could you please document the min vscode version and exact config required?
|
The instructions work for golangci-lint v2 (only), and the documentation also includes the minimum version of the VSCode extension (0.47.2). |
I am using
Vscode still does not show the lint errors in the |
If you still have the problem, can you open a dedicated discussion? And provide the following information: Your code --version code --list-extensions --show-versions | grep 'golang.go@'
# OR if you don't have grep
code --list-extensions --show-versions golangci-lint --version go version https://github.com/golangci/golangci-lint/discussions/categories/q-a |
Motivation
#5706 removed the link to vscode-go#3732 because it is resolved in the
v0.47.2
pre-release of the extension.However, the fix is not yet available for stable users — the next stable release (
v0.48.0
) is still pending.This causes confusion for stable users of the extension who still encounter the issue with golangci-lint v2 integration, as they need to search for a fix.
Changes
Added a short note under the VS Code section of the integrations page to inform users that they may need to switch to the pre-release version of the vscode-go extension if they want golangci-lint v2 integration to work properly.
Commits
docs: add note about golangci-lint v2 integration in Visual Studio Code
This commit adds a note to the docs about how to integrate
golangci-lint v2 with VS Code since the Go extension's stable
version does not support it yet.
For more information on this, you can refer to the linked
vscode-go#3732 issue comment.
Signed-off-by: lvlcn-t [email protected]
Tests done
With the new note, the integration site looks like this: