Skip to content

Update depguard version to 1.0.0 (Performance improvements) #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2019
Merged

Update depguard version to 1.0.0 (Performance improvements) #589

merged 1 commit into from
Jun 29, 2019

Conversation

hbandura
Copy link
Contributor

@hbandura hbandura commented Jun 26, 2019 •
edited
Loading

depguard was patched to improve performance on large projects, by caching checks for root packages from the import paths.

This PR merely updates depguard to version 1.0.0, and then make vendor was run.

/edit

make test was also run without issues

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hbandura hbandura mentioned this pull request Jun 26, 2019
Closed
@jirfag jirfag merged commit f8a5a8c into golangci:master Jun 29, 2019
@jirfag
Copy link
Contributor

jirfag commented Jun 29, 2019

thank you, It's a super-important fix for golangci-lint to able to work with go modules.

@tpounds tpounds mentioned this pull request Oct 3, 2019
Closed
@ldez ldez added this to the v1.18 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@hbandura @CLAassistant @jirfag @ldez