deadline is now deprecated, but should be taking its value from the configuration if set #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…es from config, is 0. Plus static check is going to fail because of deprecated cfg used
… deprecating deadline in favour of timeout
…ate usage instructions.. great!
dcaba
changed the title
|
thank you! |
jirfag
pushed a commit
that referenced
this pull request
Oct 15, 2019
…onfiguration if set (#822) * test that demostrates that deadline is not working if comes from the config * overriding timeout with deadline when only deadline is different from its default value * tests were not passing. default value for Deadline, that now only comes from config, is 0. Plus static check is going to fail because of deprecated cfg used * golangci should use the latest golangci-lint version, that is the one deprecating deadline in favour of timeout * README updated - looks the ci config in this project is used to generate usage instructions.. great!
melinath
added a commit
to hashicorp/terraform-provider-google
that referenced
this pull request
Jul 29, 2022
See golangci/golangci-lint#822 for background
melinath
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Jul 29, 2022
See golangci/golangci-lint#822 for background
melinath
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Jul 29, 2022
See golangci/golangci-lint#822 for background
melinath
added a commit
to hashicorp/terraform-provider-google
that referenced
this pull request
Jul 29, 2022
See golangci/golangci-lint#822 for background
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm afraid the PR #793 generated a side effect: while deadline still works and becomes the effective timeout setting when supplying it as a flag/cmdline arg, we've realized deadline in the configuration file is no longer being honored (ok, its deprecated, but probably we wanted this to become a breaking change, forcing all consumers to immediately change their config): see the test we are incorporating, that clearly reproduces the situation.
Proposing a fix (but not prod of it), so deadline is still considered (no matter where it comes from) if its value is different of the default timeout (that becomes a constant). There may be alternative implementations or better places to put this logic, but I didnt want to make the config package aware of the default value...
Sorry if the explanation is not clear: let me know if that is the case and I will do my best to clarify.