Fix exception causes in game_controller.py #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI failure is not related to my changes. |
|
No, we need to update the requirements to at least C++14 first, since Abseil has those requirements too now. |
|
So this PR can proceed and we can ignore the CI failure? |
|
Hang on, I'm updating the requirements to C++17, then the tests should pass. |
|
@tkoeppe Would that update come as a commit to the master branch? Because my commit is already rebased on top of the latest commit on master. |
|
I'll be in touch. I need to update a few things first, it seems. |
|
Can you please rebase and retry now? |
tomwardio
approved these changes
Jan 4, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context for this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with