Added StreamCallbacks parameter to generateContentStream() (#322) #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annhiluc
added
type:feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Added new test cases in callbacks test suite.
Used mock responses from getMockResponseStreaming.
Improved test coverage for streaming responses.
Test for onData callback: Ensures onData is called with non-empty data chunks.
Test for onError callback: Ensures onError is triggered with a GoogleGenerativeAIError when the response contains an error.
Test for onEnd callback: Ensures onEnd is correctly called with the final processed data.
Test for all callbacks: Verifies that onData and onEnd are properly called in a long response
🔹 Additional Notes:
The test suite improvements enhance the reliability of the streaming functionality by validating the correct execution of all callback functions.
all Test Cases are Passes