Skip to content

Remove duplicate test #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

Remove duplicate test #387

merged 2 commits into from
Jun 13, 2024

Conversation

mayureshagashe2105
Copy link
Contributor

  • Allow async-code-match to consider methods starting with _ (this is done to handle methods like _handle_afc and its async counterpart)
  • Remove duplicate tests

@mayureshagashe2105
Cover methods like _handle_afc
c3e290e 
Change-Id: I0f45cb8566b681f5aaeda1500e74d95eaeab10ef
@mayureshagashe2105
Remove duplicate code match test
66b50cf 
Change-Id: Ia9b7c3dcb8dd4d6bf163303b483225aa0b00e0e9
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jun 10, 2024
@markmcd markmcd merged commit 7313e21 into google-gemini:main Jun 13, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayureshagashe2105 @markmcd