Skip to content

fix genai.GenerativeModel argument name in example #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

philippemiron
Copy link
Contributor

Description of the change

Fix wrong argument in __init__.py which shows up on the website.

Motivation

The example on the documentation is not working.

Type of change

Bug fix

Checklist

  • [ x ] I have performed a self-review of my code.
  • [ x ] I have added detailed comments to my code where applicable.
  • [ x ] I have verified that my change does not break existing code.
  • [ x ] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [ x ] I am familiar with the Google Style Guide for the language I have coded in.
  • [ x ] I have read through the Contributing Guide and signed the Contributor License Agreement.

Copy link

google-cla bot commented Jun 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jun 24, 2024
@philippemiron philippemiron changed the title change argument name to model_name fix genai.GenerativeModel argument name to model_name Jun 24, 2024
@philippemiron philippemiron changed the title fix genai.GenerativeModel argument name to model_name fix genai.GenerativeModel argument name in example Jun 24, 2024
@philippemiron
Copy link
Contributor Author

Added my other email to the CLA.

Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@MarkDaoust MarkDaoust merged commit 7f1ad45 into google-gemini:main Jun 28, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jun 28, 2024
@philippemiron philippemiron deleted the fix-argument-typo branch June 28, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants