Skip to content

fix some typos #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/internal/http/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func RegisterHandlers(mux httpmux.Mux, containerManager manager.Manager, httpAut
authenticated = true
}

// Change handler based on authenticator initalization
// Change handler based on authenticator initialization
if !authenticated {
mux.HandleFunc(static.StaticResource, staticHandlerNoAuth)
if err := pages.RegisterHandlersBasic(mux, containerManager, nil, urlBasePrefix); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ kubectl kustomize deploy/kubernetes/overlays/examples_perf | kubectl apply -f -

## Kustomization

On your own fork of cAdvisor, create your own overlay directoy with your patches. Copy patches from the example folder if you intend to use them, but don't modify the originals. Commit your changes in your local branch, and use git to manage them the same way you would any other piece of code.
On your own fork of cAdvisor, create your own overlay directory with your patches. Copy patches from the example folder if you intend to use them, but don't modify the originals. Commit your changes in your local branch, and use git to manage them the same way you would any other piece of code.

To run the daemonset with your patches applied:
```
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/overlays/examples/gpu-privilages.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This patch adds the required hostpath mounts and privilages to initialize NVML, as well as to access devices.
# This patch adds the required hostpath mounts and privileges to initialize NVML, as well as to access devices.
# This patch meets the requirements described in the accellerator docs:
# https://github.com/google/cadvisor/blob/master/docs/running.md#hardware-accelerator-monitoring
apiVersion: apps/v1
Expand Down
2 changes: 1 addition & 1 deletion docs/storage/prometheus.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ Metric name | Type | Description | Unit (where applicable) | option parameter |

The table below lists the Prometheus hardware metrics exposed by cAdvisor (in alphabetical order by metric name) and corresponding `-disable_metrics` / `-enable_metrics` option parameter:

Metric name | Type | Description | Unit (where applicable) | option parameter | addional build flag |
Metric name | Type | Description | Unit (where applicable) | option parameter | additional build flag |
:-----------|:-----|:------------|:------------------------|:---------------------------|:--------------------
`machine_cpu_cache_capacity_bytes` | Gauge | Cache size in bytes assigned to NUMA node and CPU core | bytes | cpu_topology |
`machine_cpu_cores` | Gauge | Number of logical CPU cores | | |
Expand Down
2 changes: 1 addition & 1 deletion integration/tests/api/docker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func TestBasicDockerContainer(t *testing.T) {
containerInfo, err := fm.Cadvisor().Client().DockerContainer(containerID, request)
require.NoError(t, err)

// Check that the contianer is known by both its name and ID.
// Check that the container is known by both its name and ID.
sanityCheck(containerID, containerInfo, t)
sanityCheck(containerName, containerInfo, t)

Expand Down