Skip to content

fix error type in load errno from netlink response #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BSWANG
Copy link

@BSWANG BSWANG commented Jul 19, 2022

Fix invalid type error on kernel netlink return errno not zero. Should use *int32 to load errno value.

W0719 20:21:38.057540 3689835 container.go:586] Failed to update stats for container "/system.slice/kubelet.service": failed to get load stat for "/system.slice/kubelet.service" - path "/sys/fs/cgroup/system.slice/kubelet.service", error binary.Read: invalid type int32

Signed-off-by: bingshen.wbs <[email protected]>
@google-cla
Copy link

google-cla bot commented Jul 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @BSWANG. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BSWANG BSWANG changed the title fix error type in load errno fix error type in load errno from netlink response Jul 19, 2022
@bobbypage
Copy link
Collaborator

/ok-to-test

@aoxn
Copy link

aoxn commented Apr 2, 2024

+1

@aoxn
Copy link

aoxn commented Apr 2, 2024

/lgtm

@aoxn
Copy link

aoxn commented Apr 2, 2024

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants