add 32 bit architecture support #24
Conversation
@dcharkes Don't think so. https://github.community/t/does-github-actions-support-multiple-os-architectures/16526/2 Can we force Dart to run in 32 bit mode (maybe using some flags?) I test locally by running Android Emulator 😅 which is very slow in my low end machine. Otherwise, changes are done 😀. Hope this time I understood it correctly. |
There was a problem hiding this comment.
Can we force Dart to run in 32 bit mode (maybe using some flags?)
No, you need a different SDK. ia32 is available for Linux and Windows as standalone Dart: https://dart.dev/tools/sdk/archive#stable-channel
I don't think Flutter has a 32 bit SDK available: https://flutter.dev/docs/development/tools/sdk/releases?tab=linux
We don't need a GitHub actions machine that does 32 bit, just a 32 bit SDK. But since we're doing Flutter instead of Dart standalone now we can forget that. :)
src/wrapper.cc
Outdated
| @@ -127,8 +128,10 @@ Dart_CObject CallbackArgBuilder(int num, ...) { | |||
| void *request_buffer = malloc(sizeof(uint64_t) * num); | |||
| uint64_t *buf = reinterpret_cast<uint64_t *>(request_buffer); | |||
|
|
|||
| // uintptr_r will get implicitly casted to uint64_t. So, in a 32 bit machine, | |||
There was a problem hiding this comment.
re: 32 bit machine
You can run things in 32 bit mode on 64 bit machines.
Document why this is important: because its read in Dart as a 64 bit integer.
There was a problem hiding this comment.
Changed. Is the new one good?
Use an array of
uint64to store the memory addresses of arguments (of cronet callbacks). On 32 bit systems, we must store the memory address on the lower 32 bits ofuint64and upper 32 bits should be padded by0.Closes #20