-
Notifications
You must be signed in to change notification settings - Fork 610
[Windows] Remove VS Configurations #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reducing the number of configurations sounds good to me, especially at this stage where there's still a significant amount of churn. |
Also, would it be a good idea to have debug or release not both as we will have to add 2 more configurations when we add the GN builds to the example. And this would simplify the |
I plan to add a simple Debug/Release switch to Linux shortly (and macOS already supports both configurations) so I prefer to keep both for Windows. Particularly since in the example app, debug mode actually changes the Dart behavior. I'm fine with only adding GN as an option for Debug in the example VS project for now though, since the GN builds are still experimental. |
Reopening since the broken static library build options still need to be removed. |
@stuartmorgan Can you add this to In Progress in the Overview Kanban due to #209. |
I'm not really tracking status live on the Kanban board; I'll generally be updating it once or twice a week. So things like this where the time between someone starting work and the patch landing is very short will jump straight to Done, which is fine. |
jsoncpp
wasn't added to the static library builds in VS and now they are both broken.As Linux only supports outputting shared libraries I think should be reciprocate this on Windows with only dynamic libraries as the extra configurations just complicate things.
The text was updated successfully, but these errors were encountered: