[Windows] Plugin Support Not Exported #208
Assignees
Comments
|
Ah, right. I'll add an export macro and annotations, and turn on visibility hidden for Linux so they are handled consistently. |
|
Sounds reasonable |
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this issue
Jan 7, 2019
Adds export macros, and annotations for all symbols that should be public. Switches the default for shared library builds on Linux to visibility=hidden so that missing annotations will be caught on both platforms, rather than just Windows. Fixes issue google#208
|
Fixed in https://github.com/stuartmorgan/flutter-desktop-embedding/tree/library-visibility It's built on PR #183 since doing it on master would create a bunch of conflicts between the two, so it'll need to wait for that to land. I'm expect that to be this week, but in the mean time that branch can be used for experimenting with external plugins. |
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this issue
Jan 8, 2019
Adds export macros, and annotations for all symbols that should be public. Switches the default for shared library builds on Linux to visibility=hidden so that missing annotations will be caught on both platforms, rather than just Windows. Fixes issue google#208
stuartmorgan-g
pushed a commit
that referenced
this issue
Jan 8, 2019
Adds export macros, and annotations for all symbols that should be public. Switches the default for shared library builds on Linux to visibility=hidden so that missing annotations will be caught on both platforms, rather than just Windows. Fixes issue #208
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The plugin support added in #161 isn't exported on Windows so isn't actually usable in other projects. It might be easier by adding a
__declspecmacro instead of using theexports.deffile as you have to export the mangled names in some cases which isn't ideal.@clarkezone do you have any insight on how to handle this?
The text was updated successfully, but these errors were encountered: