Skip to content

Add error logging to GLFW implementation #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue Jan 21, 2019 · 0 comments · Fixed by #243
Closed

Add error logging to GLFW implementation #241

stuartmorgan-g opened this issue Jan 21, 2019 · 0 comments · Fixed by #243
Assignees
@stuartmorgan-g

Comments

@stuartmorgan-g
Copy link
Collaborator

Both the example embedders and the GLFW embedding implementation itself have error paths that don't do any logging, which makes failures harder to debug than they should be (see #240 for example). All of the error cases should log before returning/exiting.
@stuartmorgan-g stuartmorgan-g mentioned this issue Jan 22, 2019
Closed
@stuartmorgan-g stuartmorgan-g self-assigned this Jan 22, 2019
stuartmorgan-g added a commit to stuartmorgan-g/flutter-desktop-embedding that referenced this issue Jan 22, 2019
@stuartmorgan-g
Add error logging to GLFW and Flutter setup
5a38a54 
Add error logging when starting the Flutter engine fails (on all
platforms), and on GLFW errors. Also exit early with error logging for
unrecoverable errors in the GLFW implementation.

Fixes google#241.
@stuartmorgan-g stuartmorgan-g mentioned this issue Jan 22, 2019
Merged
stuartmorgan-g added a commit to stuartmorgan-g/flutter-desktop-embedding that referenced this issue Jan 22, 2019
@stuartmorgan-g
Add error logging to GLFW and Flutter setup
3e61ef2 
Add error logging when starting the Flutter engine fails (on all
platforms), and on GLFW errors. Also exit early with error logging for
unrecoverable errors in the GLFW implementation.

Fixes google#241.
stuartmorgan-g added a commit to stuartmorgan-g/flutter-desktop-embedding that referenced this issue Jan 22, 2019
@stuartmorgan-g
Add error logging to GLFW and Flutter setup
deffbb1 
Add error logging when starting the Flutter engine fails (on all
platforms), and on GLFW errors. Also exit early with error logging for
unrecoverable errors in the GLFW implementation.

Fixes google#241.
stuartmorgan-g pushed a commit that referenced this issue Jan 22, 2019
@stuartmorgan
Add error logging to GLFW and Flutter setup (#243)
54fac78 
Add error logging when starting the Flutter engine fails (on all
platforms), and on GLFW errors. Also exit early with error logging for
unrecoverable errors in the GLFW implementation.

Fixes #241.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan-g stuartmorgan-g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error logging to GLFW and Flutter setup stuartmorgan-g/flutter-desktop-embedding
1 participant
@stuartmorgan-g