-
Notifications
You must be signed in to change notification settings - Fork 610
[macOS] keyevent not implemented #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Cool! You'll need to sign the CLA as described at https://github.com/google/flutter-desktop-embedding/blob/master/CONTRIBUTING.md but otherwise just go ahead and send a PR and I can review it. (A quick note from glancing at it: it looks like all the new code is using four space indentation; code should follow the Google style guide: http://google.github.io/styleguide/objcguide.html. I'd recommend running clang-format over all the files you've edited.) |
Implements the core of raw key event handling on macOS. Uses the Android keyboard event structure, and only populates part of it for now. (Partially) addresses issue #72
I'm going to close this as fixed, and remaining work can be tracked in follow-ups if/when anyone needs more functionality (e.g., modifiers) before #47 is addressed. |
The keyDown/keyUp events which should be sent over the "flutter/keyevent" channel are not implemented in the macOS embedder. Because of that RawKeyboardListener does not work.
I got a working version in this branch: maun@b6bdb28
What would be necessary for a PR?
The text was updated successfully, but these errors were encountered: