Skip to content

[macOS] keyevent not implemented #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maun opened this issue Jun 19, 2018 · 2 comments
Closed

[macOS] keyevent not implemented #72

maun opened this issue Jun 19, 2018 · 2 comments

Comments

@maun
Copy link
Contributor

maun commented Jun 19, 2018

The keyDown/keyUp events which should be sent over the "flutter/keyevent" channel are not implemented in the macOS embedder. Because of that RawKeyboardListener does not work.

I got a working version in this branch: maun@b6bdb28

What would be necessary for a PR?

@stuartmorgan-g
Copy link
Collaborator

Cool!

You'll need to sign the CLA as described at https://github.com/google/flutter-desktop-embedding/blob/master/CONTRIBUTING.md but otherwise just go ahead and send a PR and I can review it.

(A quick note from glancing at it: it looks like all the new code is using four space indentation; code should follow the Google style guide: http://google.github.io/styleguide/objcguide.html. I'd recommend running clang-format over all the files you've edited.)

stuartmorgan-g pushed a commit that referenced this issue Aug 21, 2018
Implements the core of raw key event handling on macOS.

Uses the Android keyboard event structure, and only populates
part of it for now.

(Partially) addresses issue #72
@stuartmorgan-g
Copy link
Collaborator

I'm going to close this as fixed, and remaining work can be tracked in follow-ups if/when anyone needs more functionality (e.g., modifiers) before #47 is addressed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants