Extract codecs from plugin API #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts method codecs into stand-alone objects, and allows plugins to indicate that they use a codec other than JSON. This is an incremental step toward aligning the plugin API with Flutter's MethodChannel API. For now no other codecs are actually implemented in the framework, and the default is still JSON (unlike in existing Flutter code) so that this is not a breaking change. A future change will full move to MethodChannel, which will be a breaking change. Partially addresses issue google#67 in that custom codecs are now supported, even though the Standard (binary) codec is not yet implemented.
Corresponding Linux change. Unlike the macOS change, this is a minor breaking change; that was unavoidable due to the use of Json::Value in key interfaces. The JsonPlugin class is designed to minimize impact on existing plugins.
stuartmorgan-g
force-pushed
the
plugin-refactor-codecs
branch
from
cacb510 to
1450b21
Compare
|
Rebased onto the Linux cleanup commits; the Linux change should be less painful to review now. |
awdavies
reviewed
Aug 6, 2018
| ~EngineMethodResult(); | ||
|
|
||
| protected: | ||
| void SuccessInternal(const void *result) override; |
There was a problem hiding this comment.
Add a comment for the class which is being overridden.
awdavies
reviewed
Aug 6, 2018
macos/library/FLECodecs.h
Outdated
| - (nullable NSData*)encodeSuccessEnvelope:(nullable id)result; | ||
|
|
||
| /** | ||
| * Returns a binary encoding of |error|. Returns nil if the |details| parameter of |erorr| is not |
awdavies
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splitting of channel.* into separate files for each class, and the fact that plugin_handler was changed enough that it wasn't recognized as a move, makes the Linux change look larger than it actually is (as does the define guard and include path churn). If that gets in the way of reviewing let me know and I can retroactively create a prequel that does all the source rearranging and include path cleanup without any of the code changes.