-
Notifications
You must be signed in to change notification settings - Fork 610
Initial Linux GN build #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds an experimental GN-based build as an alternative to the Make-based build on Linux. The example application does not use GN for its own build since it is intended to serve as an example of using the embedding library, so it continues to use the more common Make as clients are unlikely to be using GN. See issue google#114
Sorry I haven't had time to take a look at this. I may not be the best reviewer anyway since I don't know a lot about GN. I'll try to find a reviewer with more knowledge. |
FWIW, I'm fine a reviewer that's not a GN expert; I can always look for an expert GN review later if this does turn out to be a viable replacement for the builds across all three platforms. |
RSLGTM. Just so I understand, the intent here is for those building the library to use GN, but those consuming the library may use other systems (e.g. Make on Linux, Xcode on Mac)? So we are looking ahead to a system where we might publish prebuilt libraries to clients rather than having them build from source? |
Exactly. Since that's the model used by Flutter, it seems like the natural direction for this project to go in longer term so that the workflows match the expectations of existing Flutter developers. |
Sounds good to me. Thanks for clarifying! |
Adds an experimental GN-based build as an alternative to the Make-based
build on Linux.
The example application does not use GN for its own build since it is
intended to serve as an example of using the embedding library, so it
continues to use the more common Make as clients are unlikely to be
using GN.
First step toward possible approach to #114