Skip to content

Initial Linux GN build #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2018
Merged

Conversation

stuartmorgan-g
Copy link
Collaborator

Adds an experimental GN-based build as an alternative to the Make-based
build on Linux.

The example application does not use GN for its own build since it is
intended to serve as an example of using the embedding library, so it
continues to use the more common Make as clients are unlikely to be
using GN.

First step toward possible approach to #114

Adds an experimental GN-based build as an alternative to the Make-based
build on Linux.

The example application does not use GN for its own build since it is
intended to serve as an example of using the embedding library, so it
continues to use the more common Make as clients are unlikely to be
using GN.

See issue google#114
@krisgiesing
Copy link
Contributor

Sorry I haven't had time to take a look at this. I may not be the best reviewer anyway since I don't know a lot about GN. I'll try to find a reviewer with more knowledge.

@stuartmorgan-g
Copy link
Collaborator Author

FWIW, I'm fine a reviewer that's not a GN expert; I can always look for an expert GN review later if this does turn out to be a viable replacement for the builds across all three platforms.

@krisgiesing
Copy link
Contributor

RSLGTM. Just so I understand, the intent here is for those building the library to use GN, but those consuming the library may use other systems (e.g. Make on Linux, Xcode on Mac)? So we are looking ahead to a system where we might publish prebuilt libraries to clients rather than having them build from source?

@stuartmorgan-g
Copy link
Collaborator Author

So we are looking ahead to a system where we might publish prebuilt libraries to clients rather than having them build from source?

Exactly. Since that's the model used by Flutter, it seems like the natural direction for this project to go in longer term so that the workflows match the expectations of existing Flutter developers.

@krisgiesing
Copy link
Contributor

Exactly. Since that's the model used by Flutter, it seems like the natural direction for this project to go in longer term so that the workflows match the expectations of existing Flutter developers.

Sounds good to me. Thanks for clarifying!

@stuartmorgan-g stuartmorgan-g merged commit 1007405 into google:master Nov 27, 2018
@stuartmorgan-g stuartmorgan-g deleted the linux-gn branch December 12, 2018 19:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants