Skip to content

Move most C++ library code to common/ and include/ #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2018

Conversation

stuartmorgan-g
Copy link
Collaborator

This is a preperatory change for Windows using all of this code. Since
it will be shared between multiple platforms, it should live in a shared
location.

Because the GN build flattens the headers in the generated out/include/,
some files have #if/#else branches for #includes. Once there is a final
decision on whether to use GN, this can be re-evaluated.

This is a preperatory change for Windows using all of this code. Since
it will be shared between multiple platforms, it should live in a shared
location.

Because the GN build flattens the headers in the generated out/include/,
some files have #if/#else branches for #includes. Once there is a final
decision on whether to use GN, this can be re-evaluated.
@stuartmorgan-g
Copy link
Collaborator Author

This extracts all the file movement from #161 into its own CL, both so that it's easier to see the Window-specific aspects of that other PR, and to decouple the in-progress C++ plugin API refactor from #161.

@franciscojma86 franciscojma86 merged commit e23e70e into google:master Dec 21, 2018
@stuartmorgan-g stuartmorgan-g deleted the cpp-file-move branch February 6, 2019 18:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants