Skip to content

[macos] Fix script handling of spaces in paths #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Collaborator

Currently building is broken when there are spaces in the path
containing the local checkout of the repository.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Currently building is broken when there are spaces in the path
containing the local checkout of the repository.
@stuartmorgan-g stuartmorgan-g force-pushed the macos-path-space-fixes branch from e2c76f5 to 33a9acd Compare January 4, 2019 03:40
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@krisgiesing krisgiesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g merged commit 370f17f into google:master Jan 4, 2019
@stuartmorgan-g stuartmorgan-g deleted the macos-path-space-fixes branch January 4, 2019 04:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants