Dart analysis-related fixes #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the include path for the example app's analysis file, which broke during the repository restructure. - Removes analysis options that are obsolete in recent Dart versions. - Fix some new analysis issues (mostly constructor ordering).
krisgiesing
reviewed
Jan 7, 2019
| @@ -4,10 +4,6 @@ | |||
|
|
|||
| # Root analysis options shared among all Dart code in the respository. Based | |||
| # on the Fuchsia standard analysis options, with some changes. | |||
| analyzer: | |||
There was a problem hiding this comment.
FWIW, there are still strong mode options that aren't the default (see implicit-casts and implicit-dynamic). We're considering trying to turn those on for our project, but they trigger a lot of analysis failures right now.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the pointer! I tried turning them on, and fixed some of the more obvious errors (added to this PR), but some of them were more fiddly, and there aren't easy-to-find example solutions for some of them, so I'm leaving them off for now.
franciscojma86
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broke during the repository restructure.