Skip to content

Fix Windows VS build #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Conversation

stuartmorgan-g
Copy link
Collaborator

Re-adds checkout of jsoncpp to build_jsonlib.bat, so that a clean VS
build on Windows build will succeed. Makes fetch_jsoncpp.dart
handle the case where the clone has already been run, so that
it can be called unconditionally from build_json.bat.

Fixes a regression from PR #191

@franciscojma86 franciscojma86 merged commit 3c62120 into google:master Jan 8, 2019
@stuartmorgan-g stuartmorgan-g deleted the windows-vs-fix branch January 8, 2019 18:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants