Remove exports.def from GN Build #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Jan 9, 2019
This is exactly what happened :( Sorry for the entirely unnecessary bustage. (I'd like to get CI set up for Windows to help avoid this kind of thing, but haven't had a chance yet.) |
I am happy to tackle this if you havn't already gotten started on it yet. How are you thinking we install the Microsoft Visual Studio Build Tools? |
|
That would be great! I'll file a bug for tracking/discussion and tag you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GN build fails as
exports.defcannot be found.