Skip to content

add support for shift, option (alt), control and command (meta) modifier keys #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

jbg
Copy link
Contributor

@jbg jbg commented Jan 19, 2019

Passes through the NSEventModifierFlag values for shift, option, control and command as Android metaState flags.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise looks good.

@stuartmorgan-g stuartmorgan-g merged commit f26ec2e into google:master Jan 21, 2019
@krisgiesing
Copy link
Contributor

Why are we using Android-defined constants here? Shouldn't we use a platform-independent description of the modifier key state?

@stuartmorgan-g
Copy link
Collaborator

Shouldn't we use a platform-independent description of the modifier key state?

There isn't one, so currently desktop on all platform is sending Android. See line 382 in this file, for instance.

@krisgiesing
Copy link
Contributor

I see, thanks for the clarification. I think we'll want to make one ourselves then, at some point.

@stuartmorgan-g
Copy link
Collaborator

Yes, the current system of using system channels and internal implementation details should be replaced with a real embedding API (essentially #47, but for key events rather than text input).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants