[linux] Improve example Makefile #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clearly separates out and documents the variables that are most likely to need to change if copying the example app. - Better differentiate between paths that are relative to the example and paths that are relative to the FDE repository, since apps using FDE would not be expected to be in the same directory the way the example is. - Add a minimal "release" mode that enables that flag to disable Dart asserts, as on macOS and Windows. - Remove the output directory override that puts the example app in the same output directory as the GN build (when building with GN). Combining them makes it less clear what's specific to the example, and what's part of building the library itself.
franciscojma86
approved these changes
Jan 22, 2019
| @@ -12,13 +12,30 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| # Example-specific variables. | |||
| # To modify this Makefile for a different application, these are the values | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to need to change if copying the example app.
and paths that are relative to the FDE repository, since apps using
FDE would not be expected to be in the same directory the way the
example is.
asserts, as on macOS and Windows.