Add Flutter tree min version check #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To minimize confusion, and reduce unnecessary issue reports, add a check during builds that the Flutter tree being used is not older than the last known point where there was a compatibility break. Instead of a runtime error, or an unexplained build error, this will fail out during the engine update step with a clear message to use a newer version of Flutter. Currently, this will ensure that people who aren't on Flutter master will get an error message that's as clear as possible.
stuartmorgan-g
force-pushed
the
flutter-min-version-check
branch
from
5337356 to
efc9915
Compare
franciscojma86
approved these changes
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize confusion, and reduce unnecessary issue reports, add a check
during builds that the Flutter tree being used is not older than the
last known point where there was a compatibility break. Instead of a
runtime error, or an unexplained build error, this will fail out during
the engine update step with a clear message to use a newer version of
Flutter.
Currently, this will ensure that people who aren't on Flutter master
will get an error message that's as clear as possible.