[linux] Switch to GN, and remove Makefiles #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the library and plugins, switch to GN as the only supported build system on Linux. GN will be used for the library in the flutter/engine repository, so the make build will no longer be necessary; remove it now to avoid the overhead of maintaining an extra build system until the transition happens. The example continues to use Make in order to show typical usage of the library, and the color_panel plugin has an example makefile (updated to reflect the use of GN to build the library) as an example/starting point for someone making a plugin outside of the FDE repository. Addresses google#114 for Linux.
franciscojma86
approved these changes
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the library and plugins, switch to GN as the only supported build
system on Linux. GN will be used for the library in the flutter/engine
repository, so the make build will no longer be necessary; remove it now
to avoid the overhead of maintaining an extra build system until the
transition happens.
The example continues to use Make in order to show typical usage of the
library, and the color_panel plugin has an example makefile (updated to
reflect the use of GN to build the library) as an example/starting point
for someone making a plugin outside of the FDE repository.
Addresses #114 for Linux.