[windows] Switch to GN for library build #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creating the PR to test the AppVeyor changes; not requesting review because it's not ready--Debug works, but Release crashes immediately. I strongly suspect this is due to #230, since the GN build isn't using the same build flags that the Release VS build uses. I'll revisit this once that work is further along. (Also, the READMEs need to be updated is part of this PR, which isn't done yet.) |
stuartmorgan-g
force-pushed
the
windows-gn-switch
branch
2 times, most recently
from
42c496a to
bbb6039
Compare
stuartmorgan-g
force-pushed
the
windows-gn-switch
branch
from
bbb6039 to
3b7fc1e
Compare
stuartmorgan-g
force-pushed
the
windows-gn-switch
branch
from
bd3575b to
09a9ded
Compare
|
AppVeyor fixed, Release works now that #230 is fixed, and the READMEs are updated. Ready for review! |
franciscojma86
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the VS-based embedder library build and updates the
example to use the GN build.
As part of the change, moves build output to
example/build/windows_fde
to match the recent change for Linux. Also eliminates the
'Dynamic Library' portion of the configuration names since
they are relics of a distinction that was removed in an earlier
change.