Move the C++ embedder code to a client wrapper #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than have a C++ interface in the shared library, make the C++ code a client wrapper layer that plugins and embedders consume. Ideally in the future more code will move out of this layer and behind a C interface in the library, so that the wrapper is as thin as possible, but this addresses the immediate issue of the shared library not having a viable interface.
|
This is definitely not the most elegant handling of the client wrapper (e.g., it should ideally either become header-only, or at least have a simplified .cc structure that makes it obvious what files different clients should include), but this gets to the general structure, resolves the problem of requiring building the whole library from source (which in turn blocks migration to flutter/engine), and should hopefully unblock the switch to GN for Windows. |
franciscojma86
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have a C++ interface in the shared library, make the C++
code a client wrapper layer that plugins and embedders build with.
Ideally in the future more code will move out of this layer and behind
a C interface in the library, so that the wrapper is as thin as
possible, but this addresses the immediate issue of the shared library
not having a viable interface.
Fixes #230