Update Keychain interface to accept repo #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 72.88% 73.15% +0.27%
==========================================
Files 91 92 +1
Lines 3835 3904 +69
==========================================
+ Hits 2795 2856 +61
Misses 689 689
- Partials 351 359 +8
Continue to review full report at Codecov.
|
mattmoor
reviewed
Sep 5, 2019
pkg/authn/keychain.go
Outdated
| ) | ||
|
|
||
| type Target interface { |
There was a problem hiding this comment.
Target isn't a great name, document this and members?
There was a problem hiding this comment.
Better idea than Target? Principal? Authority?
There was a problem hiding this comment.
authn.Target seems fine when qualified. I'm open to better suggestions.
Co-Authored-By: Matt Moore <[email protected]>
mattmoor
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
Introduces
authn.Targetwhich bothname.Repositoryandname.Registryimplement, so this should be backwards compat.