-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add pointers to structs in slices #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
@gmlewis Why was this breaking change in the API released in v29.0.3? I was expecting v29.0.3 to be interchangeable with v29.0.2 |
I apologize... that was a slip on my part. Someone asked for a new release to be created and I forgot that breaking changes were included. I don't know how to fix it now, as it seems that once a release is made, it is archived in the mod tools. To help this situation, I might be able to create a new v30.0.0 release now, but I'm afraid the damage has been done, and I'm sorry about that. |
My mistake: I don't think this was released to v29.0.3. It is one of the 17 commits since v29.0.3 |
@gmlewis However, I am seeing the incompatible master src when I |
Alright, in that case I know for a fact that we have a large number of breaking changes between v29 and v30 and I believe one or two outstanding PRs will further break things. I was planning a v30 release would happen really soon in the hopes that the breaking changes would subside for a while (many APIs have been deprecated and changed lately from the v3 API)... so if we could hold off for just a few days, I think it would be the least disruptive for all users of the repo. I'll try to prod along the outstanding PRs... but I can make no guarantees as to schedule, unfortunately. |
Taking a more detailed look, it appears that #1451 is the only one that is close that should get in before |
@joebowbeer - here's the plan - one more change is needed in #1451, then we can get #1456 approved by two LGTMs and merged, then we can release |
Since we decided in #180 to standardize using pointers to structs when they appear in slices, and some slices have slipped through code reviews without having pointers, this PR cleans these up.
Fixes: #1100.
This is a breaking API change.