Register container name with kernel before Loader.createContainerProcess(). #10998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl683064310
branch
2 times, most recently
from
e9a3be2 to
dc51377
Compare
copybara-service
bot
force-pushed
the
test/cl683064310
branch
from
dc51377 to
0fae509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register container name with kernel before Loader.createContainerProcess().
Loader.createContainerProcess() => createDeviceFiles() calls
devutil.GoferClientFromContext() when using nvidia-container-runtime-hook.
devutil.GoferClientFromContext() expects
Kernel.containerNamesmap to beinitialized with the current container's ID -> name mapping.
However, for sub-containers we were not initializing this map before
Loader.createContainerProcess(). This change fixes that. We hadn't hit this yet
because we never had multi-container usages of nvidia-container-runtime-hook.
Updates #10997