Skip to content

Unsupported enum values #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Unsupported enum values #839

wants to merge 6 commits into from

Conversation

via-guy
Copy link

@via-guy via-guy commented Mar 18, 2021

Fixes #838.

If an enum value is nullable then an unsupported value should be returned as null, to avoid crashing the parser if a new value is introduced on the repository side.

@google-cla
Copy link

google-cla bot commented Mar 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@guykogus
Copy link

@googlebot I consent

@jeiea
Copy link

jeiea commented Jun 4, 2021

I'm awaiting this PR to be merged but it stays over 2 month.
Is there anyone to comment for required next steps for being merged or reason of not being merged?

@kevmoo
Copy link
Collaborator

kevmoo commented Jun 11, 2021

@via-guy – are you able to rebase this? Does someone else want to take this over?

@via-guy
Copy link
Author

via-guy commented Jun 11, 2021

@kevmoo do you need me to rebase? You can just squash and merge, no?

@via-guy
Copy link
Author

via-guy commented Jun 11, 2021

Ah, or do you mean for post-nnbd?

@via-guy
Copy link
Author

via-guy commented Jun 11, 2021

Ah, or do you mean for post-nnbd?

I've created #917 for that

@kevmoo kevmoo closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants