added XMLLint capability for XML #93
Conversation
|
A basic test like https://github.com/google/vim-codefmt/blob/master/vroom/dartfmt.vroom would be very much appreciated |
There was a problem hiding this comment.
Can you add it to the lists in the README and in autoload/codefmt.vim / generated help file?
Re tests, the quickfix logic is involved enough it should have at least one quick bit of vroom coverage, but if you wanted to pull that out for now and just let it print an error message, I'd be fine with adding the test file myself as a follow-up change so it's more convenient for you to get something merged.
| let l:formatter = { | ||
| \ 'name': 'xmllint', | ||
| \ 'setup_instructions': 'Install xmllint. ' . | ||
| \ '(man xmllint).'} |
There was a problem hiding this comment.
"man xmllint" isn't too helpful as installation instructions. It'd only do anything if xmllint were already installed. Could you point to a website with info about how to install on various platforms?
I agree |
Signed-off-by: Ari Archer <[email protected]>
Signed-off-by: Ari Archer <[email protected]>
Second attempt to push XML rebased to ensure no original email