test: Improve Kitchen Test Logging #1914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds missing STDERR logging for improved debugging, which was missing for a while - Removes `execa`, as it is unneeded and outdated
…uth-library-nodejs into kitchen-sink-cleanup
|
Warning: This pull request is touching the following templated files:
|
d-goog
commented
Jan 22, 2025
| @@ -1041,19 +1041,19 @@ class CustomSupplier implements SubjectTokenSupplier { | |||
| } | |||
|
|
|||
| const clientOptions = { | |||
| audience: '//iam.googleapis.com/locations/global/workforcePools/$WORKLOAD_POOL_ID/providers/$PROVIDER_ID', // Set the GCP audience. | |||
| audience: '//iam.googleapis.com/locations/global/workforcePools/$WORKFORCE_POOL_ID/providers/$PROVIDER_ID', // Set the GCP audience. | |||
There was a problem hiding this comment.
Unrelated; looks like the generator didn't run last time for some reason (likely the owlbot forked PR limitation). This is safe to merge.
sofisl
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execa, as it is unneeded and outdated🦕