-
Notifications
You must be signed in to change notification settings - Fork 321
feat: Introduce compatibility with native namespace packages #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
da48f14
Add xfail test capturing desired expectation.
jaraco b606ea2
Prefer pkgutil for namespace package. Improves compatibility with nat…
jaraco 2dc9661
Merge branch 'main' into bugfix/namespace-support
parthea 03b3a4f
Merge branch 'main' into bugfix/namespace-support
jaraco 2d48fd2
⚫ Fade to black.
jaraco e6e9a56
Update to prefer native namespace package.
jaraco ceeb60f
Ensure that 'docs' and 'samples' aren't installed as top-level packages.
jaraco 721420b
Merge branch 'main' into bugfix/namespace-support
clundin25 fe2776c
Merge branch 'main' into bugfix/namespace-support
clundin25 a67c791
Merge branch 'main' into bugfix/namespace-support
clundin25 7a288a5
fix linter.
clundin25 531229b
fix mypy check
clundin25 724870e
Merge branch 'main' into bugfix/namespace-support
clundin25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import os | ||
import subprocess | ||
import sys | ||
|
||
|
||
def test_namespace_package_compat(tmp_path): | ||
""" | ||
The ``google`` namespace package should not be masked | ||
by the presence of ``google-auth``. | ||
""" | ||
google = tmp_path / "google" | ||
google.mkdir() | ||
google.joinpath("othermod.py").write_text("") | ||
env = dict(os.environ, PYTHONPATH=str(tmp_path)) | ||
cmd = [sys.executable, "-m", "google.othermod"] | ||
subprocess.check_call(cmd, env=env) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.